Conversation
.jpg "Pull LCD driver code into main #7")
simen and others added 30 commits 12 years ago
.png "Pull LCD driver code into main #7"){kind=avatar}
Member
simen commented on Feb 11, 2011
|
I will not add this code to the core Grbl because it is very specific to external hardware. I am planning to enable Grbl to function as an i2c slave to that it can be connected to another device that takes care of UI or adds other capabilities. This will keep the core as simple and general as possible. |
ashelly pushed a commit to ashelly/grbl that referenced this pull request on May 22, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
.png&h=110&w=185&q=90&zc=1&ct=1)
.jpg&h=110&w=185&q=90&zc=1&ct=1)
.png&h=110&w=185&q=90&zc=1&ct=1)
.png&h=110&w=185&q=90&zc=1&ct=1)
Hi Simen
I’ve been adding code to support a 2×16 LCD, and learning far more about git than I ever wanted to. I made the changes on your master branch, then merged your bugfixes back into my additions. I’ve tried to make my commits free standing and easy for you to pull, but I’ll leave that up to you! There are a couple of commits that reflect my lack of knowledge about git.
I found that your rate calculations caused the app to fail on my Duemilanove, but commenting them out had no ill effects. I can’t explain why they should cause the app to fail, except that there might be a divide by zero?